Skip to content

Fix Content-Type header for cached APIResponse#7697

Merged
mdellweg merged 1 commit intopulp:mainfrom
gerrod3:capiche
May 8, 2026
Merged

Fix Content-Type header for cached APIResponse#7697
mdellweg merged 1 commit intopulp:mainfrom
gerrod3:capiche

Conversation

@gerrod3
Copy link
Copy Markdown
Contributor

@gerrod3 gerrod3 commented May 8, 2026

ApiResponse overwrites the Content-Type header with the passed in content_type argument on initialization, so we need to save it to the cache to ensure the cached response still has the original header.

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

@mdellweg mdellweg merged commit 84a6c2e into pulp:main May 8, 2026
13 of 14 checks passed
@patchback
Copy link
Copy Markdown

patchback Bot commented May 8, 2026

Backport to 3.49: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 84a6c2e on top of patchback/backports/3.49/84a6c2e6d9e615bf6de7b58531cd749d557f3c68/pr-7697

Backporting merged PR #7697 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.49/84a6c2e6d9e615bf6de7b58531cd749d557f3c68/pr-7697 upstream/3.49
  4. Now, cherry-pick PR Fix Content-Type header for cached APIResponse #7697 contents into that branch:
    $ git cherry-pick -x 84a6c2e6d9e615bf6de7b58531cd749d557f3c68
    If it'll yell at you with something like fatal: Commit 84a6c2e6d9e615bf6de7b58531cd749d557f3c68 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 84a6c2e6d9e615bf6de7b58531cd749d557f3c68
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix Content-Type header for cached APIResponse #7697 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.49/84a6c2e6d9e615bf6de7b58531cd749d557f3c68/pr-7697
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 8, 2026

Backport to 3.63: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.63/84a6c2e6d9e615bf6de7b58531cd749d557f3c68/pr-7697

Backported as #7699

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 8, 2026

Backport to 3.73: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.73/84a6c2e6d9e615bf6de7b58531cd749d557f3c68/pr-7697

Backported as #7700

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 8, 2026

Backport to 3.85: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.85/84a6c2e6d9e615bf6de7b58531cd749d557f3c68/pr-7697

Backported as #7701

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 8, 2026

Backport to 3.105: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.105/84a6c2e6d9e615bf6de7b58531cd749d557f3c68/pr-7697

Backported as #7702

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 8, 2026

Backport to 3.110: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.110/84a6c2e6d9e615bf6de7b58531cd749d557f3c68/pr-7697

Backported as #7703

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants